chore: add linter & fix errors #578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -26,7 +26,7 @@ | |||
| "e2e:generate-fixtures": "npm run --workspace=test/func/fixtures generate", | |||
| "e2e:test": "npm run --workspace=test/func/tests test", | |||
| "e2e": "npm run e2e:build-packages && npm run e2e:generate-fixtures ; npm run e2e:test", | |||
| "lint": "eslint .", | |||
| "lint": "eslint . --ext .js,.jsx,.ts,.tsx", | |||
There was a problem hiding this comment.
Can we specify this in .eslintrc.js itself?
There was a problem hiding this comment.
I'm not sure. Looks like .eslintrc.js has no such option.
shadowusr
approved these changes
Jul 23, 2024
| @@ -103,7 +103,7 @@ describe('<BrowserTitle/>', () => { | |||
| const browsersStateById = {'yabro': {checkStatus: UNCHECKED}}; | |||
| const tree = mkStateTree({browsersById, resultsById, browsersStateById}); | |||
|
|
|||
| const component = mkBrowserTitleComponent({browserId: 'yabro', browserName: 'yabro'}, {tree}); | |||
| mkBrowserTitleComponent({browserId: 'yabro', browserName: 'yabro'}, {tree}); | |||
There was a problem hiding this comment.
Does this line do anything? As far as I can tell we are just callling a function that returns a value and ignore the value.
There was a problem hiding this comment.
Yes. It calls a stub that is used in assert inside the component.
| @@ -35,6 +35,9 @@ describe('<ScreenshotAccepter/>', () => { | |||
| }; | |||
|
|
|||
| const mkScreenshotAccepterComponent = (props = {}, initialState = {}) => { | |||
| if (!global.Element.prototype.scrollTo) { | |||
| @@ -116,7 +116,7 @@ describe('<RunButton />', () => { | |||
|
|
|||
| it('should switch to "Run checked tests" if there are checked tests', () => { | |||
| selectorsStub.getCheckedTests.returns([{testName: 'testName', browserName: 'browserName'}]); | |||
| const component = mkConnectedComponent(<RunButton />, { | |||
| mkConnectedComponent(<RunButton />, { | |||
There was a problem hiding this comment.
Yes. It calls a stub that is used in assert inside the component.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable linter for .jsx, .ts and .tsx.